Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(barcode-scanning): fixed CameraPermissionState type #97

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix(barcode-scanning): fixed CameraPermissionState type #97

merged 1 commit into from
Nov 13, 2023

Conversation

frankmarazita
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

The CameraPermissionState type was using the Typescript PermissionState instead of the Capacitor PermissionState which includes prompt-with-rationale.

robingenz
robingenz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@robingenz robingenz merged commit ca9dc94 into capawesome-team:main Nov 13, 2023
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankmarazita @robingenz